Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suzannah Kirk-Daligcon #49

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Suzannah Kirk-Daligcon #49

wants to merge 35 commits into from

Conversation

sckirk
Copy link

@sckirk sckirk commented Sep 9, 2016

Kari, I'm curious to hear your general comments about this project.

What I'd like to learn more about are... class variables.
Are we "allowed" to use them?
I looked at how Allison used class variables in her .all methods.

What happens if someone adds one line to the CSV file?
The class variable will not be updated, correct?
Phrased a different way, class variables are always stagnant once initiated, correct?

If my understanding above is accurate--is there a way to use a class variable in the .all methods AND be able to update this variable when new line(s) are added to the associated CSV files?

sckirk and others added 30 commits September 6, 2016 12:27
…reated two tests, and created the code in the market class to pass the first test.
…d the remaining 3 spec files; and created two tests and code to complete Vendors baseline.
… product and the sale classes--completing my baseline requirements.
…leaned up the initialize tests by using let across two tests.
… pass the test, and double-checked via Ruby testing in FarMar.
…l and self.find(id)--then wrote the code to pass the tests.
…ll and self.find(id)--then wrote the code to pass the tests.
…and self.find(id)--then wrote the code to pass the tests.
…pass TDD, then looked at the actual output via far_mar.rb test Ada-C6#9
… pass TDD, then looked at the actual output via far_mar.rb test Ada-C6#10
…hen looked at the actual output via far_mar.rb test Ada-C6#11
…well as the self.by_vendor method (in Product class) sections to confirm that the id's of the objects returned by the class method matches the id passed into the method.
…en looked at the actual output via far_mar.rb test Ada-C6#12
…then looked at the actual output via far_mar.rb test Ada-C6#13
…n looked at the actual output via far_mar.rb test Ada-C6#14
…hen looked at the actual output via far_mar.rb test Ada-C6#15
…hen looked at the actual output via far_mar.rb test Ada-C6#16
…en looked at the actual output via far_mar.rb test Ada-C6#17
…ss TDD, then looked at the actual output via far_mar.rb test Ada-C6#18
…lass method... thanks to Karin for helping me see this connection this morning while working on the Sale.vendor method.
…n looked at the actual output via far_mar.rb test Ada-C6#20
…uent code to pass TDD, then looked at the actual output via far_mar.rb test Ada-C6#21
… the hierarchy and make the tests a little more efficient
…ents (except the sale.between method because this has an argument error built in if arguments in a different format other than DateTime are passed in) to raise Argument Errors if an argument was passed in that didn't exist as a possible ID in the csv files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant