forked from Ada-C5/FarMar
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suzannah Kirk-Daligcon #49
Open
sckirk
wants to merge
35
commits into
Ada-C6:master
Choose a base branch
from
sckirk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reated two tests, and created the code in the market class to pass the first test.
…d the remaining 3 spec files; and created two tests and code to complete Vendors baseline.
… product and the sale classes--completing my baseline requirements.
…leaned up the initialize tests by using let across two tests.
… pass the test, and double-checked via Ruby testing in FarMar.
…l and self.find(id)--then wrote the code to pass the tests.
…ll and self.find(id)--then wrote the code to pass the tests.
…and self.find(id)--then wrote the code to pass the tests.
…pass TDD, then looked at the actual output via far_mar.rb test Ada-C6#9
…d everything out to return later
… pass TDD, then looked at the actual output via far_mar.rb test Ada-C6#10
…hen looked at the actual output via far_mar.rb test Ada-C6#11
…well as the self.by_vendor method (in Product class) sections to confirm that the id's of the objects returned by the class method matches the id passed into the method.
…en looked at the actual output via far_mar.rb test Ada-C6#12
…then looked at the actual output via far_mar.rb test Ada-C6#13
…n looked at the actual output via far_mar.rb test Ada-C6#14
…hen looked at the actual output via far_mar.rb test Ada-C6#15
…hen looked at the actual output via far_mar.rb test Ada-C6#16
…en looked at the actual output via far_mar.rb test Ada-C6#17
…ss TDD, then looked at the actual output via far_mar.rb test Ada-C6#18
… looked at the actual output via far_mar.rb test Ada-C6#19
…lass method... thanks to Karin for helping me see this connection this morning while working on the Sale.vendor method.
…n looked at the actual output via far_mar.rb test Ada-C6#20
…uent code to pass TDD, then looked at the actual output via far_mar.rb test Ada-C6#21
… the hierarchy and make the tests a little more efficient
…ents (except the sale.between method because this has an argument error built in if arguments in a different format other than DateTime are passed in) to raise Argument Errors if an argument was passed in that didn't exist as a possible ID in the csv files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kari, I'm curious to hear your general comments about this project.
What I'd like to learn more about are... class variables.
Are we "allowed" to use them?
I looked at how Allison used class variables in her .all methods.
What happens if someone adds one line to the CSV file?
The class variable will not be updated, correct?
Phrased a different way, class variables are always stagnant once initiated, correct?
If my understanding above is accurate--is there a way to use a class variable in the .all methods AND be able to update this variable when new line(s) are added to the associated CSV files?